Revisit the failed attempt to correct MidoriView

diff --git a/midori/midori-view.c b/midori/midori-view.c
index 9bd03bec5266cd29d7e43974e3c2ca134995d891..0ee351195ca3231d58e56b8e810ff2829b47f5f3 100644 (file)
--- a/midori/midori-view.c
+++ b/midori/midori-view.c
@@ -1402,17 +1402,19 @@ midori_view_set_settings (MidoriView*        view,
         return;
 
     if (view->settings)
-    {
         g_signal_handlers_disconnect_by_func (view->settings,
             midori_view_settings_notify_cb, view);
+
+    katze_object_assign (view->settings, settings);
+    if (settings)
+    {
         g_object_ref (settings);
         if (view->web_view)
-            g_object_set (view->web_view, "settings", view->settings, NULL);
+            g_object_set (view->web_view, "settings", settings, NULL);
         _midori_view_update_settings (view);
         g_signal_connect (settings, "notify",
             G_CALLBACK (midori_view_settings_notify_cb), view);
     }
-    katze_object_assign (view->settings, settings);
     g_object_notify (G_OBJECT (view), "settings");
 }