]> spindle.queued.net Git - midori/commitdiff
Don't emit add-download before all preparations
authorChristian Dywan <christian@twotoasts.de>
Sun, 6 Mar 2011 16:20:18 +0000 (17:20 +0100)
committerChristian Dywan <christian@twotoasts.de>
Sun, 6 Mar 2011 16:26:40 +0000 (17:26 +0100)
Notably verifying that there's space available and a file
shouldn't be overriden has to come first. This already was
the case for the transferbar which isn't using the signal.

midori/midori-browser.c

index 0efb183751bbf8a177828d90c859b44c5dfbf21a..325aef93770ac1da8782f485da1ce4055edb9bae 100644 (file)
@@ -983,6 +983,7 @@ midori_browser_prepare_download (MidoriBrowser*  browser,
     }
 
     webkit_download_set_destination_uri (download, uri);
+    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     midori_transferbar_add_download_item (MIDORI_TRANSFERBAR (browser->transferbar), download);
     return TRUE;
 }
@@ -1416,7 +1417,6 @@ midori_view_download_requested_cb (GtkWidget*      view,
                                    WebKitDownload* download,
                                    MidoriBrowser*  browser)
 {
-    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     if (!webkit_download_get_destination_uri (download))
     {
         gchar* folder;