Merge gtk_init into midori_app_setup

gtk_init must come before stock items but we
need to copy the arguments before.

Fixes: https://bugs.launchpad.net/midori/+bug/1033043

diff --git a/midori/main.c b/midori/main.c
index 57ee6f3b043bbe9da7b22703ab00db49659701fe..874421cc875d573b019702ee9e3b8998076e2030 100644 (file)
--- a/midori/main.c
+++ b/midori/main.c
@@ -2004,8 +2004,6 @@ main (int    argc,
     #endif
     #endif
 
-    midori_app_setup (argv);
-
     /* Parse cli options */
     webapp = NULL;
     config = NULL;
@@ -2022,8 +2020,7 @@ main (int    argc,
     block_uris = NULL;
     inactivity_reset = 0;
     error = NULL;
-    if (!gtk_init_with_args (&argc, &argv, _("[Addresses]"), entries,
-                             GETTEXT_PACKAGE, &error))
+    if (!midori_app_setup (&argc, &argv, entries, &error))
     {
         g_print ("%s - %s\n", _("Midori"), error->message);
         g_error_free (error);

diff --git a/midori/midori-app.c b/midori/midori-app.c
index f27562c127333ded99300bb8551484dfa2b3c135..3b6e48019ca1b60a49ed7309cba5a15734e83462 100644 (file)
--- a/midori/midori-app.c
+++ b/midori/midori-app.c
@@ -1434,14 +1434,18 @@ midori_app_get_lib_path (const gchar* package)
  *
  * Since: 0.4.2
  **/
-void
-midori_app_setup (gchar** argument_vector)
+gboolean
+midori_app_setup (gint               *argc,
+                  gchar**            *argument_vector,
+                  const GOptionEntry *entries,
+                  GError*            *error)
 {
     GtkIconSource* icon_source;
     GtkIconSet* icon_set;
     GtkIconFactory* factory;
     gsize i;
     gchar* executable;
+    gboolean success;
 
     static GtkStockItem items[] =
     {
@@ -1488,7 +1492,11 @@ midori_app_setup (gchar** argument_vector)
     textdomain (GETTEXT_PACKAGE);
     #endif
 
-    g_type_init ();
+    /* Preserve argument vector */
+    command_line = g_strdupv (*argument_vector);
+    success = gtk_init_with_args (argc, argument_vector, _("[Addresses]"),
+                                  entries, GETTEXT_PACKAGE, error);
+
     factory = gtk_icon_factory_new ();
     for (i = 0; i < G_N_ELEMENTS (items); i++)
     {
@@ -1504,8 +1512,6 @@ midori_app_setup (gchar** argument_vector)
     gtk_icon_factory_add_default (factory);
     g_object_unref (factory);
 
-    /* Preserve argument vector */
-    command_line = g_strdupv (argument_vector);
     #ifdef G_OS_WIN32
     exec_path = g_win32_get_package_installation_directory_of_module (NULL);
     #else
@@ -1550,6 +1556,8 @@ midori_app_setup (gchar** argument_vector)
         }
     }
     #endif
+
+    return success;
 }
 
 gboolean

diff --git a/midori/midori-app.h b/midori/midori-app.h
index a8fae5eb9887d2b6be43dbec2e38490cc7764601..de0015ee306e72a547293bd1e71519e06bb35b45 100644 (file)
--- a/midori/midori-app.h
+++ b/midori/midori-app.h
@@ -82,8 +82,11 @@ midori_app_send_notification      (MidoriApp*         app,
                                    const gchar*       title,
                                    const gchar*       message);
 
-void
-midori_app_setup                  (gchar**            argument_vector);
+gboolean
+midori_app_setup                  (gint               *argc,
+                                   gchar**            *argument_vector,
+                                   const GOptionEntry *entries,
+                                   GError*            *error);
 
 gchar**
 midori_app_get_command_line       (void);

diff --git a/tests/bookmarks.c b/tests/bookmarks.c
index 9a135936075f2bc75acf49b49b9f586590d02c2c..bce08d7f76e52bcc1c3a3bab041e8f1e1088f988 100644 (file)
--- a/tests/bookmarks.c
+++ b/tests/bookmarks.c
@@ -195,9 +195,7 @@ main (int    argc,
     //TestParameters default_params = {":memory:", TRUE, NULL, NULL};
     TestParameters default_params = {":memory:", FALSE, NULL, NULL};
 
-    midori_app_setup (argv);
-    g_test_init (&argc, &argv, NULL);
-    gtk_init_check (&argc, &argv);
+    midori_app_setup (&argc, &argv, NULL, NULL);
 
     g_test_add ("/bookmarks/simple test",
                     BookmarksFixture, &default_params,

diff --git a/tests/browser.c b/tests/browser.c
index c6fda193f4364f57e16a70753c7ee42bd7b3803c..5b9ee85ea33df6a9e26f08059e235fed25845879 100644 (file)
--- a/tests/browser.c
+++ b/tests/browser.c
@@ -130,11 +130,10 @@ int
 main (int    argc,
       char** argv)
 {
-    midori_app_setup (argv);
     g_object_set_data (G_OBJECT (webkit_get_default_session ()),
                        "midori-session-initialized", (void*)1);
     g_test_init (&argc, &argv, NULL);
-    gtk_init_check (&argc, &argv);
+    midori_app_setup (&argc, &argv, NULL, NULL);
 
     g_test_add_func ("/browser/create", browser_create);
     g_test_add_func ("/browser/tooltips", browser_tooltips);

diff --git a/tests/extensions.c b/tests/extensions.c
index a5baa1fa86c13b8a86294c723f1102e4c44ec21c..3da96cd865ea851747fd07133032e09cd7e43004 100644 (file)
--- a/tests/extensions.c
+++ b/tests/extensions.c
@@ -245,9 +245,8 @@ int
 main (int    argc,
       char** argv)
 {
-    midori_app_setup (argv);
     g_test_init (&argc, &argv, NULL);
-    gtk_init_check (&argc, &argv);
+    midori_app_setup (&argc, &argv, NULL, NULL);
     soup_session_add_feature_by_type (webkit_get_default_session (),
         SOUP_TYPE_COOKIE_JAR);
 

diff --git a/tests/magic-uri.c b/tests/magic-uri.c
index 8a3a73cdfa9ec97607809dbf00924d8ee741b008..35f5781c80162062a1c7f965dfd6544468e1b294 100644 (file)
--- a/tests/magic-uri.c
+++ b/tests/magic-uri.c
@@ -334,9 +334,8 @@ int
 main (int    argc,
       char** argv)
 {
-    midori_app_setup (argv);
     g_test_init (&argc, &argv, NULL);
-    gtk_init_check (&argc, &argv);
+    midori_app_setup (&argc, &argv, NULL, NULL);
 
     g_test_add_func ("/magic-uri/uri", magic_uri_uri);
     g_test_add_func ("/magic-uri/idn", magic_uri_idn);

diff --git a/tests/properties.c b/tests/properties.c
index e6d299474be398f73a869c124db6d18f825d6bc8..d6abd2f19d09cc1173e12dccb31f7d2526604454 100644 (file)
--- a/tests/properties.c
+++ b/tests/properties.c
@@ -187,11 +187,10 @@ int
 main (int    argc,
       char** argv)
 {
-    midori_app_setup (argv);
     g_object_set_data (G_OBJECT (webkit_get_default_session ()),
                        "midori-session-initialized", (void*)1);
     g_test_init (&argc, &argv, NULL);
-    gtk_init_check (&argc, &argv);
+    midori_app_setup (&argc, &argv, NULL, NULL);
 
     g_test_add_data_func ("/properties/app",
         (gconstpointer)MIDORI_TYPE_APP, properties_type_test);