]> spindle.queued.net Git - midori/commitdiff
Print file saving errors to the standard output
authorBrian Vuyk <brian@brianvuyk.com>
Tue, 18 Nov 2008 22:18:53 +0000 (23:18 +0100)
committerChristian Dywan <christian@twotoasts.de>
Tue, 18 Nov 2008 22:18:53 +0000 (23:18 +0100)
katze/katze-net.c
midori/midori-browser.c

index d1e88eee184e76c8ee743176a0ab14ef663c82d3..0df4e2dc78204debe8c7fe8f40fbb0d9b3fa48c5 100644 (file)
@@ -433,8 +433,8 @@ katze_net_icon_transfer_cb (KatzeNetRequest*  request,
             fclose (fp);
             if ((ret - request->length) != 0)
             {
-                /*  FIXME: We need error handling. If this is called,
-                    it means there was a write error */
+                g_warning ("Error writing to file %s "
+                           "in katze_net_icon_transfer_cb()", priv->icon_file);
             }
             pixbuf = gdk_pixbuf_new_from_file (priv->icon_file, NULL);
         }
index a6a6f6465a8e4cba5194c21477ec33f4500ce7fe..903f6716bb7fd7eeacb1670c838c5377a824ee62 100644 (file)
@@ -641,15 +641,16 @@ midori_browser_save_transfer_cb (KatzeNetRequest* request,
 
     if (request->data)
     {
-        /* FIXME: Show an error message if the file cannot be saved */
         if ((fp = fopen (filename, "wb")))
         {
             ret = fwrite (request->data, 1, request->length, fp);
             fclose (fp);
             if ((ret - request->length) != 0)
             {
-                /*  FIXME: We need error handling. If this is called,
-                    i means there was a write error */
+                /* Once we have a download interface this should be
+                   indicated graphically. */
+                g_warning ("Error writing to file %s "
+                           "in midori_browser_save_transfer_cb", filename);
             }
         }
     }
@@ -1866,8 +1867,9 @@ midori_browser_source_transfer_cb (KatzeNetRequest* request,
                 fclose (fp);
                 if ((ret - request->length) != 0)
                 {
-                    /*  FIXME: We need error handling. If this is called,
-                        it means there was a write error */
+                    /* FIXME: Show an error in the graphical interface */
+                    g_warning ("Error writing to file %s "
+                               "in midori_browser_source_transfer_cb()", filename);
                 }
                 g_object_get (browser->settings,
                     "text-editor", &text_editor, NULL);