]> spindle.queued.net Git - midori/commitdiff
Disconnect bookmark removal callback with the right data argument
authorChristian Dywan <christian@twotoasts.de>
Wed, 16 Sep 2009 21:48:06 +0000 (23:48 +0200)
committerChristian Dywan <christian@twotoasts.de>
Wed, 16 Sep 2009 23:03:24 +0000 (01:03 +0200)
It would not actually disconnect before because it was disconnected
with the wrong user data, and thus crash in a multiple window
scenario when a bookmark was deleted.

midori/midori-browser.c

index f406d929b9848c940d105154854d17dd329d58e3..649119e1d043c1223e1e8da9ec02a9267c25b730 100644 (file)
@@ -5807,7 +5807,7 @@ midori_browser_set_bookmarks (MidoriBrowser* browser,
         g_signal_handlers_disconnect_by_func (
             browser->bookmarks, browser_bookmarks_add_item_cb, browser->bookmarkbar);
         g_signal_handlers_disconnect_by_func (
-            browser->bookmarks, browser_bookmarks_remove_item_cb, browser->bookmarkbar);
+            browser->bookmarks, browser_bookmarks_remove_item_cb, browser);
     }
 
     if (bookmarks)