From: Christian Dywan <christian@twotoasts.de>
Date: Sun, 6 Mar 2011 16:20:18 +0000 (+0100)
Subject: Don't emit add-download before all preparations
X-Git-Url: https://spindle.queued.net/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=663e7e9285807130999aa9615635f7a037422956;p=midori

Don't emit add-download before all preparations

Notably verifying that there's space available and a file
shouldn't be overriden has to come first. This already was
the case for the transferbar which isn't using the signal.
---

diff --git a/midori/midori-browser.c b/midori/midori-browser.c
index 0efb1837..325aef93 100644
--- a/midori/midori-browser.c
+++ b/midori/midori-browser.c
@@ -983,6 +983,7 @@ midori_browser_prepare_download (MidoriBrowser*  browser,
     }
 
     webkit_download_set_destination_uri (download, uri);
+    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     midori_transferbar_add_download_item (MIDORI_TRANSFERBAR (browser->transferbar), download);
     return TRUE;
 }
@@ -1416,7 +1417,6 @@ midori_view_download_requested_cb (GtkWidget*      view,
                                    WebKitDownload* download,
                                    MidoriBrowser*  browser)
 {
-    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     if (!webkit_download_get_destination_uri (download))
     {
         gchar* folder;