From: Christian Dywan <christian@twotoasts.de>
Date: Sun, 1 Jul 2012 20:00:23 +0000 (+0200)
Subject: Remove window flashing on new tabs
X-Git-Url: https://spindle.queued.net/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef4ee2f63426742c337f1292543a6eb83e9074ba;p=midori

Remove window flashing on new tabs

The flashing can be distracting to some users. We
may re-visit the feature if we find a better behavior.

The setting stays to avoid resetting old config files.
---

diff --git a/midori/midori-browser.c b/midori/midori-browser.c
index 45544709..ca0ac0ff 100644
--- a/midori/midori-browser.c
+++ b/midori/midori-browser.c
@@ -1249,23 +1249,6 @@ midori_browser_view_copy_history (GtkWidget* view_to,
     }
 }
 
-static gboolean
-midori_browser_notify_new_tab_timeout_cb (MidoriBrowser *browser)
-{
-    gtk_window_set_opacity (GTK_WINDOW (browser), 1);
-    return G_SOURCE_REMOVE;
-}
-
-static void
-midori_browser_notify_new_tab (MidoriBrowser *browser)
-{
-    if (katze_object_get_boolean (browser->settings, "flash-window-on-new-bg-tabs"))
-    {
-        gtk_window_set_opacity (GTK_WINDOW (browser), 0.8);
-        g_timeout_add (100, (GSourceFunc) midori_browser_notify_new_tab_timeout_cb, browser);
-    }
-}
-
 static void
 midori_view_new_tab_cb (GtkWidget*     view,
                         const gchar*   uri,
@@ -1278,8 +1261,6 @@ midori_view_new_tab_cb (GtkWidget*     view,
 
     if (!background)
         midori_browser_set_current_page (browser, n);
-    else
-        midori_browser_notify_new_tab (browser);
 }
 
 static void
@@ -1315,8 +1296,6 @@ midori_view_new_view_cb (GtkWidget*     view,
         gint n = midori_browser_add_tab (browser, new_view);
         if (where != MIDORI_NEW_VIEW_BACKGROUND)
             midori_browser_set_current_page (browser, n);
-        else
-            midori_browser_notify_new_tab (browser);
     }
 
     if (!user_initiated)
diff --git a/midori/midori-preferences.c b/midori/midori-preferences.c
index 4b5ff613..c291995c 100644
--- a/midori/midori-preferences.c
+++ b/midori/midori-preferences.c
@@ -392,13 +392,10 @@ midori_preferences_set_settings (MidoriPreferences* preferences,
     else
         button = katze_property_proxy (settings, "middle-click-opens-selection", NULL);
     INDENTED_ADD (button);
-    button = katze_property_proxy (settings, "flash-window-on-new-bg-tabs", NULL);
-    SPANNED_ADD (button);
-
     if (katze_object_has_property (settings, "enable-webgl"))
     {
         button = katze_property_proxy (settings, "enable-webgl", NULL);
-        INDENTED_ADD (button);
+        SPANNED_ADD (button);
     }
 
     FRAME_NEW (NULL);
diff --git a/midori/midori-websettings.c b/midori/midori-websettings.c
index 85290d9b..846a17ce 100644
--- a/midori/midori-websettings.c
+++ b/midori/midori-websettings.c
@@ -822,6 +822,13 @@ midori_web_settings_class_init (MidoriWebSettingsClass* class)
         !midori_web_settings_low_memory_profile (),
                                                            flags));
     #endif
+    /**
+     * MidoriWebSettings::flash-window-on-new-bg-tabs
+     *
+     * Doesn't do anything.
+     *
+     * Deprecated: 0.4.7
+     */
     g_object_class_install_property (gobject_class,
                                      PROP_FLASH_WINDOW_ON_BG_TABS,
                                      g_param_spec_boolean (