From c6bdd62f671e597cc3a125c235c9ddd733861942 Mon Sep 17 00:00:00 2001 From: Christian Dywan Date: Sun, 11 Mar 2012 21:38:02 +0100 Subject: [PATCH] Correctly skip link items if there is no | Parsing will still ignore items containing a , anywhere. --- midori/midori-view.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/midori/midori-view.c b/midori/midori-view.c index 4fab0270..eeaf13d9 100644 --- a/midori/midori-view.c +++ b/midori/midori-view.c @@ -1488,6 +1488,7 @@ webkit_web_view_load_finished_cb (WebKitWebView* web_view, "} return f; })(" "document.getElementsByTagName ('link'));", NULL); + /* FIXME: If URI or title contains , parsing will break */ gchar** items = g_strsplit (value, ",", 0); gchar** current_item = items; gchar* default_uri = NULL; @@ -1511,7 +1512,7 @@ webkit_web_view_load_finished_cb (WebKitWebView* web_view, continue; title = strchr (uri_and_title, '|'); if (title == NULL) - continue; + goto news_feeds_continue; title++; uri = g_strndup (uri_and_title, title - 1 - uri_and_title); @@ -1529,6 +1530,7 @@ webkit_web_view_load_finished_cb (WebKitWebView* web_view, katze_assign (view->icon_uri, g_strdup (uri_and_title)); #endif + news_feeds_continue: current_item++; } g_strfreev (items); -- 2.39.5